Messages in this thread | | | Date | Tue, 3 Aug 2010 08:45:17 -0700 | From | Jesse Barnes <> | Subject | Re: [PATCH 08/11] x86: intel_ips: do not use PCI resources before pci_enable_device() |
| |
On Tue, 3 Aug 2010 19:44:16 +0400 Kulikov Vasiliy <segooon@gmail.com> wrote:
> IRQ and resource[] may not have correct values until > after PCI hotplug setup occurs at pci_enable_device() time. > > The semantic match that finds this problem is as follows: > > // <smpl> > @@ > identifier x; > identifier request ~= "pci_request.*|pci_resource.*"; > @@ > > ( > * x->irq > | > * x->resource > | > * request(x, ...) > ) > ... > *pci_enable_device(x) > // </smpl> > > Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> > --- > drivers/platform/x86/intel_ips.c | 11 ++++++----- > 1 files changed, 6 insertions(+), 5 deletions(-)
Yep, thanks.
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
-- Jesse Barnes, Intel Open Source Technology Center
| |