lkml.org 
[lkml]   [2010]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] nconfig: add search support
    From
    On Tue, Aug 3, 2010 at 12:22 AM,  <rdunlap@xenotime.net> wrote:
    > On Sun, August 1, 2010 12:20 am, nir.tzachar@gmail.com wrote:
    >> From: Nir Tzachar <nir.tzachar@gmail.com>
    >>
    >>
    >> Remove the old hotkeys feature, and replace by a regular string search.
    >> From nconfig help:
    >>
    >>
    >> Pressing '/' triggers search mode. nconfig does regular string match,
    >> case insensitive, starting at the begining of each menu line. Pressing
    >> Enter highlights the next match, Backspace removes one character from
    >> the match string. Pressing either '/' again or ESC exits search mode.
    >>
    >> Rebind the '/' key (which allowed to search for symbols) to F8
    >>
    >>
    >> Signed-off-by: Nir Tzachar <nir.tzachar@gmail.com>
    >> ---
    >> scripts/kconfig/nconf.c |  261
    >> ++++++++++++++++++++++-------------------------
    >> scripts/kconfig/nconf.h |    3 +- 2 files changed, 125 insertions(+), 139
    >> deletions(-)
    >
    >
    > A few other comments:
    >
    > These help text lines should end with a period:
    >
    >  Pressing SpaceBar toggles between the above options
    >
    >  <Esc> always leaves the current window
    >

    Sure.

    > The F-key help along the bottom line should be forced to fit
    > into 80 columns.  F9 (exit) especially should be visible.

    They were, however I think that the symbol search (F-8) kind of ruind
    it. I'll shorten its name.

    >
    > This F3 should be F5:
    >
    >  Press <Esc>, <F3> or <left-arrow> to go back one menu,

    10x.

    >
    > How about we make nconfig the default in linux-next
    > so that it will be used more?

    I would love to see that. Let me finalize a patch which properly
    supports searching (based on Sam's input) so as to remove the current
    upper case ugliness.

    Cheers.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-08-03 06:43    [W:3.627 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site