Messages in this thread | | | Date | Tue, 03 Aug 2010 13:15:35 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH 1/2 block#for-2.6.36] bio, fs: update RWA_MASK, READA and SWRITE to match the corresponding BIO_RW_* bits |
| |
On 2010-08-03 11:53, Tejun Heo wrote: > Commit a82afdf (block: use the same failfast bits for bio and request) > moved BIO_RW_* bits around such that they match up with REQ_* bits. > Unfortunately, fs.h hard coded RW_MASK, RWA_MASK, READ, WRITE, READA > and SWRITE as 0, 1, 2 and 3, and expected them to match with BIO_RW_* > bits. READ/WRITE didn't change but BIO_RW_AHEAD was moved to bit 4 > instead of bit 1, breaking RWA_MASK, READA and SWRITE. > > This patch updates RWA_MASK, READA and SWRITE such that they match the > BIO_RW_* bits again. A follow up patch will update the definitions to > directly use BIO_RW_* bits so that this kind of breakage won't happen > again. > > Neil also spotted missing RWA_MASK conversion. > > Stable: The offending commit a82afdf was released with v2.6.32, so > this patch should be applied to all kernels since then but it must > _NOT_ be applied to kernels earlier than that. > > Signed-off-by: Tejun Heo <tj@kernel.org> > Reported-and-bisected-by: Vladislav Bolkhovitin <vst@vlnb.net> > Root-caused-by: Neil Brown <neilb@suse.de> > Cc: Jens Axobe <axboe@kernel.dk> ^^^^^
(Too) common typo :-)
Anyway, applied to for-2.6.36, thanks a lot.
-- Jens Axboe
| |