Messages in this thread | | | Date | Sun, 29 Aug 2010 11:49:07 -0400 | From | Rik van Riel <> | Subject | Re: [PATCH] vmscan: prevent background aging of anon page in no swap system |
| |
On 08/29/2010 11:43 AM, Minchan Kim wrote:
> This patch prevents unnecessary anon pages demotion in not-swapon and > non-configured swap system. Of course, it could make side effect that > hot anon pages could swap out when admin does swap on. > But I think sooner or later it would be steady state. > So it's not a big problem. > We could lose someting but gain more thing(TLB flush and unnecessary > function call to demote anon pages).
A agree that is not a big worry. I expect virtually all the systems with swap space will do swapon at boot time.
> I used total_swap_pages because we want to age anon pages > even though swap full happens. > > Cc: Rik van Riel<riel@redhat.com> > Cc: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com> > Cc: Johannes Weiner<hannes@cmpxchg.org> > Reported-by: Ying Han<yinghan@google.com> > Signed-off-by: Minchan Kim<minchan.kim@gmail.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
-- All rights reversed
| |