| | From | Roland McGrath <> | | Subject | Re: [RFC PATCH 00/43] ptrace cleanups | | Date | Sun, 29 Aug 2010 17:14:54 -0700 (PDT) |
| |
I am fine with the s/long/unsigned long/ signature changes. Adding temporaries to avoid the repeated casts is fine too. All that will compile away to the same code we have now. But please do it without changing put_user/get_user calls to copy_{to,from}_user. With a temporary or two you'll still have fewer casts than before. IMHO you should at least do a separate follow-on patch for anything that actually changes the compiled code vs just the cosmetic type cleanups.
Thanks, Roland
|