lkml.org 
[lkml]   [2010]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 10/11] x86: Remove unnecessary ifdefs from i387 code.
    From
    On Sun, Aug 29, 2010 at 3:00 PM, Pekka Enberg <penberg@kernel.org> wrote:
    > On Sat, Aug 28, 2010 at 7:04 PM, Brian Gerst <brgerst@gmail.com> wrote:
    >> Remove ifdefs for code that the compiler can optimize away on 64-bit.
    >>
    >> Signed-off-by: Brian Gerst <brgerst@gmail.com>
    >
    >> @@ -74,10 +74,8 @@ static void __cpuinit init_thread_xstate(void)
    >>
    >>        if (cpu_has_fxsr)
    >>                xstate_size = sizeof(struct i387_fxsave_struct);
    >> -#ifdef CONFIG_X86_32
    >>        else
    >>                xstate_size = sizeof(struct i387_fsave_struct);
    >> -#endif
    >>  }
    >
    > I guess this is OK but keep in mind that cpu_has_fsxr is _not_
    > optimized by the compiler on 64-bit so the change probably increases
    > kernel text by few bytes.
    >
    > Acked-by: Pekka Enberg <penberg@kernel.org>
    >

    FXSR is a required feature on 64-bit, therefore cpu_has_fxsr is always true.

    --
    Brian Gerst
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-08-30 01:41    [W:0.021 / U:157.784 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site