Messages in this thread | | | Date | Sun, 29 Aug 2010 22:00:52 +0300 | Subject | Re: [PATCH 10/11] x86: Remove unnecessary ifdefs from i387 code. | From | Pekka Enberg <> |
| |
On Sat, Aug 28, 2010 at 7:04 PM, Brian Gerst <brgerst@gmail.com> wrote: > Remove ifdefs for code that the compiler can optimize away on 64-bit. > > Signed-off-by: Brian Gerst <brgerst@gmail.com>
> @@ -74,10 +74,8 @@ static void __cpuinit init_thread_xstate(void) > > if (cpu_has_fxsr) > xstate_size = sizeof(struct i387_fxsave_struct); > -#ifdef CONFIG_X86_32 > else > xstate_size = sizeof(struct i387_fsave_struct); > -#endif > }
I guess this is OK but keep in mind that cpu_has_fsxr is _not_ optimized by the compiler on 64-bit so the change probably increases kernel text by few bytes.
Acked-by: Pekka Enberg <penberg@kernel.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |