lkml.org 
[lkml]   [2010]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] perf: Remove newline character from perror() argument
Date
If we include a newline character in the string argument to perror()
then the output will be split across two lines like so,

Unable to read perf file descriptor
: No space left on device

Deleting the newline character prints a much more readable error,

Unable to read perf file descriptor: No space left on device

Signed-off-by: Matt Fleming <matt@console-pimps.org>
---
tools/perf/builtin-record.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index ff77b80..b530bee 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -353,7 +353,7 @@ try_again:
}

if (read(fd[nr_cpu][counter][thread_index], &read_data, sizeof(read_data)) == -1) {
- perror("Unable to read perf file descriptor\n");
+ perror("Unable to read perf file descriptor");
exit(-1);
}

@@ -626,7 +626,7 @@ static int __cmd_record(int argc, const char **argv)

nr_cpus = read_cpu_map(cpu_list);
if (nr_cpus < 1) {
- perror("failed to collect number of CPUs\n");
+ perror("failed to collect number of CPUs");
return -1;
}

--
1.7.1


\
 
 \ /
  Last update: 2010-08-28 17:49    [from the cache]
©2003-2011 Jasper Spaans