lkml.org 
[lkml]   [2010]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 7/7] net/wireless: Remove double test
    Date
    The same expression is tested twice and the result is the same each time.

    The sematic match that finds this problem is as follows:
    (http://coccinelle.lip6.fr/)

    // <smpl>
    @expression@
    expression E;
    @@

    (
    * E
    || ... || E
    |
    * E
    && ... && E
    )
    // </smpl>

    Signed-off-by: Julia Lawall <julia@diku.dk>

    ---
    net/wireless/wext-core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/net/wireless/wext-core.c b/net/wireless/wext-core.c
    index 0ef17bc..4038593 100644
    --- a/net/wireless/wext-core.c
    +++ b/net/wireless/wext-core.c
    @@ -611,7 +611,7 @@ struct iw_statistics *get_wireless_stats(struct net_device *dev)
    #endif

    #ifdef CONFIG_CFG80211_WEXT
    - if (dev->ieee80211_ptr && dev->ieee80211_ptr &&
    + if (dev->ieee80211_ptr &&
    dev->ieee80211_ptr->wiphy &&
    dev->ieee80211_ptr->wiphy->wext &&
    dev->ieee80211_ptr->wiphy->wext->get_wireless_stats)


    \
     
     \ /
      Last update: 2010-08-28 17:45    [W:0.019 / U:2.948 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site