lkml.org 
[lkml]   [2010]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [lm-sensors] [Patch-next] therm_throt.c: fix missing { and }.
    On Thu, 26 Aug 2010 17:29:05 +0900, Jin Dongming wrote:
    > When the feature PTS is not supported by CPU, the sysfile
    > package_power_limit_count for package should not be generated.
    >
    > This patch is used for fixing missing { and }. But I have not confirmed
    > this patch because I don't have such machine.
    >
    > Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
    > ---
    > arch/x86/kernel/cpu/mcheck/therm_throt.c | 3 ++-
    > 1 files changed, 2 insertions(+), 1 deletions(-)
    >
    > diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
    > index d9368ee..169d880 100644
    > --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
    > +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
    > @@ -216,7 +216,7 @@ static __cpuinit int thermal_throttle_add_dev(struct sys_device *sys_dev,
    > err = sysfs_add_file_to_group(&sys_dev->kobj,
    > &attr_core_power_limit_count.attr,
    > thermal_attr_group.name);
    > - if (cpu_has(c, X86_FEATURE_PTS))
    > + if (cpu_has(c, X86_FEATURE_PTS)) {
    > err = sysfs_add_file_to_group(&sys_dev->kobj,
    > &attr_package_throttle_count.attr,
    > thermal_attr_group.name);
    > @@ -224,6 +224,7 @@ static __cpuinit int thermal_throttle_add_dev(struct sys_device *sys_dev,
    > err = sysfs_add_file_to_group(&sys_dev->kobj,
    > &attr_package_power_limit_count.attr,
    > thermal_attr_group.name);
    > + }
    >
    > return err;
    > }

    This is incomplete. Error handling in this function is totally broken.


    --
    Jean Delvare


    \
     
     \ /
      Last update: 2010-08-27 15:23    [W:4.434 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site