lkml.org 
[lkml]   [2010]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 8/8] ideapad: Change the driver name to ideapad_laptop
    From
    On Thu, Aug 26, 2010 at 8:16 AM, Ike Panhc <ike.pan@canonical.com> wrote:
    > On 08/26/2010 01:43 PM, Corentin Chary wrote:
    >> On Wed, Aug 25, 2010 at 10:56 PM, Len Brown <lenb@kernel.org> wrote:
    >>>>  drivers/platform/x86/ideapad_acpi.c   |  381 ---------------------------------
    >>>>  drivers/platform/x86/ideapad_laptop.c |  381 +++++++++++++++++++++++++++++++++
    >>>
    >>> Acked-by: Len Brown <len.brown@intel.com>
    >>>
    >>> thanks,
    >>> Len Brown, Intel Open Source Technology Center
    >>>
    >>> --
    >>> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
    >>> the body of a message to majordomo@vger.kernel.org
    >>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
    >>>
    >>
    >> Probably not very important .. but .. other drivers are called *-laptop.c, not
    >> *_laptop.c ..
    >>
    >> asus-laptop.c classmate-laptop.c compal-laptop.c dell-laptop.c eeepc-laptop.c
    >> fujitsu-laptop.c msi-laptop.c panasonic-laptop.c sony-laptop.c topstar-laptop.c
    >>
    > I choose _laptop.c not -laptop.c because when modprobe. We are using
    > "modprobe asus-laptop", but when removing, using "modprobe asus_laptop".
    >

    Hum, that's a "bug" in asus-laptop, because I used KBUILD_MODNAME
    (asus_laptop) instead
    of "asus-laptop" as the driver name. And I don't know if I can change
    that now without breaking
    backward compatibility.

    But other drivers should work (I tested sony-laptop).

    --
    Corentin Chary
    http://xf.iksaif.net
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-08-26 09:45    [W:0.081 / U:0.304 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site