lkml.org 
[lkml]   [2010]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] Gigabit Ethernet driver of Topcliff PCH
    From
    Date
    On Thu, 2010-08-26 at 09:05 -0700, Stephen Hemminger wrote:
    > + for (i = 0; i < 6; i++)
    > + printk(KERN_INFO "%2.2x%c",
    > + netdev->dev_addr[i], i == 5 ? '\n' : ':');
    >
    > you just want:
    > printk(KERN_INFO "%pM", netdev->dev_addr);
    >
    > or better yet, convert to dev_printk

    or perhaps better still convert to netdev_info

    My message logging order preference:

    if there's a netif_msg_<type> and a struct net_device
    netif_<level> (struct private *, netif_msg_<type>,
    struct net_device *, fmt, args...)
    if there's a struct net_device
    netdev_<level> (struct net_device *, fmt, args...)
    if there's a struct device
    dev_<level> (struct device *, fmt, args...)
    otherwise
    pr_<level> (fmt, args...)




    \
     
     \ /
      Last update: 2010-08-26 18:19    [W:0.023 / U:31.436 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site