Messages in this thread |  | | | Subject | Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH | | From | Joe Perches <> | | Date | Thu, 26 Aug 2010 09:16:12 -0700 |
| |
On Thu, 2010-08-26 at 09:05 -0700, Stephen Hemminger wrote: > + for (i = 0; i < 6; i++) > + printk(KERN_INFO "%2.2x%c", > + netdev->dev_addr[i], i == 5 ? '\n' : ':'); > > you just want: > printk(KERN_INFO "%pM", netdev->dev_addr); > > or better yet, convert to dev_printk
or perhaps better still convert to netdev_info
My message logging order preference:
if there's a netif_msg_<type> and a struct net_device netif_<level> (struct private *, netif_msg_<type>, struct net_device *, fmt, args...) if there's a struct net_device netdev_<level> (struct net_device *, fmt, args...) if there's a struct device dev_<level> (struct device *, fmt, args...) otherwise pr_<level> (fmt, args...)
|  |