lkml.org 
[lkml]   [2010]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/8] hugetlb: add allocate function for hugepage migration
    > +static struct page *alloc_buddy_huge_page_node(struct hstate *h, int nid)
    > +{
    > + struct page *page = __alloc_huge_page_node(h, nid);
    > if (page) {
    > - if (arch_prepare_hugepage(page)) {
    > - __free_pages(page, huge_page_order(h));
    > + set_compound_page_dtor(page, free_huge_page);
    > + spin_lock(&hugetlb_lock);
    > + h->nr_huge_pages++;
    > + h->nr_huge_pages_node[nid]++;
    > + spin_unlock(&hugetlb_lock);
    > + put_page_testzero(page);
    > + }
    > + return page;
    > +}

    One would expect the alloc_buddy_huge_page_node() to only differ with
    alloc_buddy_huge_page() in the alloc_pages/alloc_pages_exact_node
    calls. However you implement alloc_buddy_huge_page_node() in a quite
    different way. Can the two functions be unified at all?

    Thanks,
    Fengguang


    \
     
     \ /
      Last update: 2010-08-25 03:33    [W:0.050 / U:1.376 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site