Messages in this thread | | | Date | Tue, 24 Aug 2010 17:11:22 -0700 | Subject | Re: [PATCH 1/5] cgroup: ID notification call back | From | Paul Menage <> |
| |
On Tue, Aug 24, 2010 at 2:04 AM, Li Zefan <lizf@cn.fujitsu.com> wrote: > > Maybe pass the id number to id_attached() is better. > > And actually the @ss argument is not necessary, because the memcg's > id_attached() handler of course knows it's dealing with the memory > cgroup subsystem. > > So I suspect we can just remove all the @ss from all the callbacks..
Yes, I don't think any subsystem uses these. They dated originally from when, as part of the initial cgroups framwork, I included a library that could wrap a mostly-unmodified CKRM resource controller into a cgroups subsystem, at which point the callback code didn't necessarily know which subsystem it was being called for. But that's obsolete now.
Paul
| |