lkml.org 
[lkml]   [2010]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] mfd: da903x - fix da903x_add_subdevs error path
Axel Lin wrote:
> This patch fixes da903x_add_subdevs error path:
> 1. return -ENOMEM if platform_device_alloc() fail.
> 2. call platform_device_put() if platform_device_add() fail.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Acked-by: Mike Rapoport <mike@compulab.co.il>

> ---
> drivers/mfd/da903x.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
> index c07aece..2fadbae 100644
> --- a/drivers/mfd/da903x.c
> +++ b/drivers/mfd/da903x.c
> @@ -470,13 +470,19 @@ static int __devinit da903x_add_subdevs(struct da903x_chip *chip,
> subdev = &pdata->subdevs[i];
>
> pdev = platform_device_alloc(subdev->name, subdev->id);
> + if (!pdev) {
> + ret = -ENOMEM;
> + goto failed;
> + }
>
> pdev->dev.parent = chip->dev;
> pdev->dev.platform_data = subdev->platform_data;
>
> ret = platform_device_add(pdev);
> - if (ret)
> + if (ret) {
> + platform_device_put(pdev);
> goto failed;
> + }
> }
> return 0;
>


--
Sincerely yours,
Mike.


\
 
 \ /
  Last update: 2010-08-24 08:17    [W:0.078 / U:0.040 seconds]
©2003-2014 Jasper Spaans. Advertise on this site