lkml.org 
[lkml]   [2010]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 11/18] Coccinelle: Add api/kstrdup.cocci
    Date
    Use kstrdup rather than duplicating its implementation

    Signed-off-by: Nicolas Palix <npalix@diku.dk>
    Signed-off-by: Julia Lawall <julia@diku.dk>
    ---
    scripts/coccinelle/api/kstrdup.cocci | 39 ++++++++++++++++++++++++++++++++++
    1 files changed, 39 insertions(+), 0 deletions(-)
    create mode 100644 scripts/coccinelle/api/kstrdup.cocci

    diff --git a/scripts/coccinelle/api/kstrdup.cocci b/scripts/coccinelle/api/kstrdup.cocci
    new file mode 100644
    index 0000000..e0805ad
    --- /dev/null
    +++ b/scripts/coccinelle/api/kstrdup.cocci
    @@ -0,0 +1,39 @@
    +/// Use kstrdup rather than duplicating its implementation
    +///
    +// Confidence: High
    +// Copyright: (C) 2010 Nicolas Palix, DIKU. GPLv2.
    +// Copyright: (C) 2010 Julia Lawall, DIKU. GPLv2.
    +// Copyright: (C) 2010 Gilles Muller, INRIA/LiP6. GPLv2.
    +// URL: http://coccinelle.lip6.fr/
    +// Comments:
    +// Options: -no_includes -include_headers
    +
    +virtual patch
    +
    +@@
    +expression from,to;
    +expression flag,E1,E2;
    +statement S;
    +@@
    +
    +- to = kmalloc(strlen(from) + 1,flag);
    ++ to = kstrdup(from, flag);
    + ... when != \(from = E1 \| to = E1 \)
    + if (to==NULL || ...) S
    + ... when != \(from = E2 \| to = E2 \)
    +- strcpy(to, from);
    +
    +@@
    +expression x,from,to;
    +expression flag,E1,E2,E3;
    +statement S;
    +@@
    +
    +- x = strlen(from) + 1;
    + ... when != \( x = E1 \| from = E1 \)
    +- to = \(kmalloc\|kzalloc\)(x,flag);
    ++ to = kstrdup(from, flag);
    + ... when != \(x = E2 \| from = E2 \| to = E2 \)
    + if (to==NULL || ...) S
    + ... when != \(x = E3 \| from = E3 \| to = E3 \)
    +- memcpy(to, from, x);
    --
    1.7.0.4


    \
     
     \ /
      Last update: 2010-08-24 17:45    [W:0.043 / U:2.220 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site