lkml.org 
[lkml]   [2010]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] workqueue: mark lock acquisition on worker_maybe_bind_and_lock()
On 08/22/2010 04:19 PM, Namhyung Kim wrote:
> worker_maybe_bind_and_lock() actually grabs gcwq->lock but was missing proper
> annotation. Add it. So this patch will remove following sparse warnings:
>
> kernel/workqueue.c:1214:13: warning: context imbalance in 'worker_maybe_bind_and_lock' - wrong count at exit
> arch/x86/include/asm/irqflags.h:44:9: warning: context imbalance in 'worker_rebind_fn' - unexpected unlock
> kernel/workqueue.c:1991:17: warning: context imbalance in 'rescuer_thread' - unexpected unlock
>
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>

applied to wq#for-linus. Thanks.

Also, please considering putting related patches into a thread. For
short series, just chaining them is good enough (ie. patch n+1 is
reply to patch n). For longer series, writing up a head message with
overall description, diffstat and other general info about the patch
series and making all patches reaplies to the head message is a good
idea.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2010-08-23 11:49    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site