Messages in this thread | | | Date | Mon, 23 Aug 2010 22:50:24 -0400 | From | Josef Bacik <> | Subject | Re: [PATCH 4/6] btrfs: update stats when allocating from a cluster |
| |
On Tue, Aug 24, 2010 at 08:50:57AM +0800, Li Zefan wrote: > >> spin_unlock(&cluster->lock); > >> > >> + if (!ret) > >> + return 0; > >> + > >> + spin_lock(&block_group->tree_lock); > >> + > >> + block_group->free_space -= bytes; > >> + if (entry->bytes == 0) { > >> + block_group->free_extents--; > >> + kfree(entry); > >> + } > >> + > >> + spin_unlock(&block_group->tree_lock); > >> + > > > > Move this part up so we don't drop the spinlock and then re-grab it. Thanks, > > > > But they are 2 different locks. ;) > > And we can't grab block_group->tree_lock when holding cluster->lock.
Ugh Jesus sorry, ignore me.
Reviewed-by: Josef Bacik <josef@redhat.com>
Thanks,
Josef
| |