Messages in this thread |  | | | Date | Tue, 24 Aug 2010 09:19:22 +0900 | | From | Daisuke Nishimura <> | | Subject | Re: [PATCH 4/5] memcg: lockless update of file_mapped |
| |
On Tue, 24 Aug 2010 08:49:16 +0900 KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> On Mon, 23 Aug 2010 17:50:15 +0900 > Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote: > > > This patch looks good to me, but I have one question. > > > > Why do we need to acquire sc.lock inside mem_cgroup_(start|end)_move() ? > > These functions doesn't access mc.*. > > > > just reusing a lock to update status. If you don't like, I'll add a new lock. > I see. I think it would be enough just to add some comments about it.
Thanks, Daisuke Nishimura.
|  |