Messages in this thread |  | | | Date | Mon, 23 Aug 2010 12:31:23 +0200 | | From | Jens Axboe <> | | Subject | Re: [PATCH] blk-fs: put dev->kobj in blk_register_queue fail path |
| |
On 2010-08-13 12:44, Xiaotian Feng wrote: > kernel needs to kobject_put on dev->kobj if elv_register_queue fails. > > Signed-off-by: Xiaotian Feng <dfeng@redhat.com> > Cc: Jens Axboe <axboe@kernel.dk> > Cc: "Martin K. Petersen" <martin.petersen@oracle.com> > Cc: Stephen Hemminger <shemminger@vyatta.com> > Cc: Nikanth Karthikesan <knikanth@suse.de> > Cc: David Teigland <teigland@redhat.com> > --- > block/blk-sysfs.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c > index 001ab18..0749b89 100644 > --- a/block/blk-sysfs.c > +++ b/block/blk-sysfs.c > @@ -511,6 +511,7 @@ int blk_register_queue(struct gendisk *disk) > kobject_uevent(&q->kobj, KOBJ_REMOVE); > kobject_del(&q->kobj); > blk_trace_remove_sysfs(disk_to_dev(disk)); > + kobject_put(&dev->kobj); > return ret; > } >
Looks correct. Thanks, applied.
-- Jens Axboe
|  |