[lkml]   [2010]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/2] MFD: Align ab8500 with the abx500 interface
    2010/8/20 Samuel Ortiz <>:
    > On Tue, Aug 17, 2010 at 11:24:37AM +0200, Mattias Wallin wrote:

    >> This patch makes the ab8500 mixed signal chip expose the same
    >> interface for register access as the ab3100, ab3550 and ab5500 chip.
    >> The ab8500_read() and ab8500_write() is removed and replaced with
    >> abx500_get_register_interruptible() and
    >> abx500_set_register_interruptible().

    > Thanks for the patch, but I'd prefer to see it split into 3 separate ones, for
    > mfd, rtc and regulator. And then have the relevant maintaines cc'ed with those
    > patches.

    ... but that will have the side effect of making it non-bisectable will
    it not? If we change the interface of AB8500 to abx500.h in one
    patch that breaks the users and the order is not restored until all
    patches are applied.

    Isn't it better to just resend the same patch and Cc: the relevant
    subsystem maintainers on it?

    I'll sign it off and do this, I should've been in the submit path

    If you prefer to have it non-bisectable I'll post yet another version
    for that.

    Linus Walleij

     \ /
      Last update: 2010-08-21 11:17    [W:0.046 / U:1.884 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site