lkml.org 
[lkml]   [2010]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] gpio/stmpe: add bitmask to block requests to unavailable GPIOs
Hi Rabin,

On Thu, Aug 19, 2010 at 06:36:05PM +0530, Rabin Vincent wrote:
> On Wed, Aug 18, 2010 at 12:31:37 +0200, Wolfram Sang wrote:
> > On Wed, Aug 18, 2010 at 03:39:50PM +0530, Rabin VINCENT wrote:
> > > On Mon, Aug 16, 2010 at 17:14:44 +0200, Wolfram Sang wrote:
> > > > GPIOs on these controller are multi-functional. If you decided to use
> > > > some of them e.g. as input channels for the ADC, you surely don't want
> > > > those pins to be reassigned as simple GPIOs (which may be triggered even
> > > > from userspace via 'export'). Same for the touchscreen controller pins.
> > > > Since knowledge about the hardware is needed to decide which GPIOs to
> > > > reserve, let this bitmask be inside platform_data and provide some
> > > > defines to assist potential users.
> > >
> > > Could this be done without the platform data, say something like the
> > > below? (Though this does assume that nobody tries to request GPIOs
> > > before the STMPE subdrivers reserve their pins.)
> > >
> >
> > While I'd also like to skip the additional platform_data entry, your
> > last comment is in deed a drawback.
>
> Yes, especially if the subdrivers are dynamically loaded. Your patch is
> fine with me:
>
> Acked-by: Rabin Vincent <rabin.vincent@stericsson.com>
>
> The only minor comment is that the STMPE_GPIO_NOREQ_811_TOUCH name could
> perhaps be clearer. STMPE811_GPIO_NOREQ_TOUCHSCREEN, maybe?
I applied Wolfram's patch. If he wants to change this name, he can send an
additional patch later on.

Thanks for the patch and the review.

Cheers,
Samuel.


> Rabin

--
Intel Open Source Technology Centre
http://oss.intel.com/


\
 
 \ /
  Last update: 2010-08-21 00:27    [W:0.145 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site