Messages in this thread | | | Subject | Re: [PATCH v3] netfilter: save the hash of the tuple in the original direction for latter use | From | Eric Dumazet <> | Date | Fri, 20 Aug 2010 17:29:23 +0200 |
| |
Le vendredi 20 août 2010 à 23:22 +0800, Changli Gao a écrit :
> I should keep the old way, but fix a race. > > if (unlikely(!nf_conntrack_hash_rnd_initted)) { > get_random_bytes(&nf_conntrack_hash_rnd, > sizeof(nf_conntrack_hash_rnd)); > nf_conntrack_hash_rnd_initted = 1; > } > > nf_conntrack_alloc() isn't called with in the nf_conntrack_lock. So > the above code maybe executed more than once on different CPUs. It is > easy to fix with the cmpxchg() trick.
Sure, please fix the race first.
But as I said, its not critical, if one or two conntracks are hashed on wrong basis. They will eventually disappear after timeout.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |