lkml.org 
[lkml]   [2010]   [Aug]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4] initramfs: remove sparse warnings
On Thu, Aug 19, 2010 at 04:38:23PM +0200, Arnd Bergmann wrote:
> On Thursday 19 August 2010, Namhyung Kim wrote:
> > This patchset removes most of sparse warnings in init/initramfs.c.
> > Current implementation of initramfs relies on syscall service rountins heavily
> > so it requires many of arguments to be __user address space pointers but, in
> > most cases, were missing proper markups. This patchset tries to fix those at
> > a minimum change.
>
> I'm skeptical about this, you are adding obviously incorrect annotations
> to the code to make something work that was written without the awareness
> for address spaces.
>
> A better way would be to call path_lookup or kern_path to look up the
> path and pass that to a lower-level file I/O function.

No. This code should *NOT* use the VFS guts, TYVM. The whole fscking point
is that this puppy is a sequence of plain vanilla syscalls, ideally run
simply in userland thread. We used to have a magical mystery shite in there
and it had been a huge PITA.


\
 
 \ /
  Last update: 2010-08-20 14:03    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site