lkml.org 
[lkml]   [2010]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] KVM: MMU: mark page dirty only when page is really written


Avi Kivity wrote:
> On 07/27/2010 06:35 AM, Xiao Guangrong wrote:
>> Mark page dirty only when this page is really written, it's more exacter,
>> and also can fix dirty page marking in speculation path
>>
>> Signed-off-by: Xiao Guangrong<xiaoguangrong@cn.fujitsu.com>
>> ---
>> arch/x86/kvm/mmu.c | 47
>> ++++++++++++++++++++++++++++-------------------
>> 1 files changed, 28 insertions(+), 19 deletions(-)
>>
>> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
>> index dd6c192..bcc2173 100644
>> --- a/arch/x86/kvm/mmu.c
>> +++ b/arch/x86/kvm/mmu.c
>> @@ -311,24 +311,42 @@ static bool spte_bits_lost(u64 spte)
>> if (!is_shadow_present_pte(spte))
>> return false;
>>
>> - if (spte& shadow_accessed_mask)
>> + if (spte& shadow_accessed_mask&&
>> + (!is_writable_pte(spte) || spte& shadow_dirty_mask))
>> return false;
>>
>
> Please add parentheses around bitwise operators to reduce confusion.
> The rest looks good.
>

OK, will do it in the new version, thanks.


\
 
 \ /
  Last update: 2010-08-02 09:59    [W:1.380 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site