Messages in this thread | | | Date | Tue, 3 Aug 2010 02:08:47 +0200 | From | Alessandro Zummo <> | Subject | Re: [PATCH v2 3/3] rtc: Add MAX8998 rtc driver |
| |
On Mon, 02 Aug 2010 16:35:07 +0900 Joonyoung Shim <jy0922.shim@samsung.com> wrote:
> This adds support for the RTC provided by the Maxim 8998 chip. This > driver was tested on a GONI board by using the rtc-test application from > the Documentation/rtc.txt. > > Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > Acked-by: Samuel Ortiz <sameo@linux.intel.com>
Seems nice. I'd add rtc_valid_tm where appropriate. And maybe free that irq you requested ;)
pending those changes, you have my
Acked-by: Alessandro Zummo <a.zummo@towertech.it>
--
Best regards,
Alessandro Zummo, Tower Technologies - Torino, Italy
http://www.towertech.it
| |