Messages in this thread | | | Date | Tue, 3 Aug 2010 00:36:59 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH 1/2] x86, setup: reorgize the early_console_setup |
| |
On Mon, Aug 02, 2010 at 01:30:17PM -0700, Yinghai Lu wrote: ... > >> + /* make sure if it is copied already */ > >> + if (boot_params.hdr.version) > >> + return; > >> + > > > > And Yinghai, lets be more verbose here a bit, since for those who will > > be reading this code later might be non-obvious why we have checked for > > 'version' here. I guess something like "an easy way to check if boot_params > > were already copied". Actually it's clean from commit message but I think > > we first read code comments and commit messages after, agreed? ;-) > > will change to > > /* > * hdr.version is always not 0, so check it to see > * if boot_params is copied or not. > */ > > will resend this patch after memblock x86 changes. > > YH >
ok, thanks!
-- Cyrill
| |