lkml.org 
[lkml]   [2010]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] x86, setup: reorgize the early_console_setup
From
On Mon, Aug 2, 2010 at 2:56 PM, Thiago Farina <tfransosi@gmail.com> wrote:
> On Mon, Aug 2, 2010 at 4:13 AM, Yinghai Lu <yinghai@kernel.org> wrote:
>> Index: linux-2.6/arch/x86/boot/string.c
>> ===================================================================
>> --- linux-2.6.orig/arch/x86/boot/string.c
>> +++ linux-2.6/arch/x86/boot/string.c
>> @@ -12,7 +12,21 @@
>>  * Very basic string functions
>>  */
>>
>> -#include "boot.h"
>> +static inline int isdigit(int ch)
>> +{
>> +       return (ch >= '0') && (ch <= '9');
>> +}
>> +
>> +static inline int isxdigit(int ch)
>> +{
>> +       if (isdigit(ch))
>> +               return true;
>> +
>> +       if ((ch >= 'a') && (ch <= 'f'))
>> +               return true;
>> +
>> +       return (ch >= 'A') && (ch <= 'F');
>> +}
>>
>
> These to functions above can be fairly simplified by writting as:
>
> static bool inline is_hex_digit(int c) {
>  return (c >= '0' && c <= '9') ||
>            (c >= 'A' && c <= 'F') ||
>            (c >= 'a' && c <= 'f');
> }
>

Wow, sorry, this should be:

static inline bool is_hex_digit(int c) { ... }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-08-02 20:03    [W:0.135 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site