Messages in this thread | | | Date | Mon, 2 Aug 2010 14:37:55 +0200 | From | Wim Van Sebroeck <> | Subject | Re: [PATCH] watchdog: Add watchdog driver for OCTEON SOCs (v2). |
| |
Hi David, Ralf,
> The OCTEON is a MIPS64 based SOC family with an on chip watchdog unit. > > The driver is split into two source files one for the C code and one > for assembly. Assembly is needed to handle the NMI and then print the > machine state before the reboot is triggered. > > v2: Stylistic changes suggested by Sam Ravnborg.
This v2 looks good. only small remark is: > +static struct notifier_block octeon_wdt_cpu_notifier = { > + .notifier_call = octeon_wdt_cpu_callback > +};
Add a comma after octeon_wdt_cpu_callback.
> Signed-off-by: David Daney <ddaney@caviumnetworks.com> > Cc: Wim Van Sebroeck <wim@iguana.be>
Signed-off-by: Wim Van Sebroeck <wim@iguana.be>
> Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Russell King <rmk+kernel@arm.linux.org.uk> > Cc: Tony Lindgren <tony@atomide.com> > Cc: Marc Zyngier <maz@misterjones.org> > Cc: Thierry Reding <thierry.reding@avionic-design.de> > Cc: Sam Ravnborg <sam@ravnborg.org>
Kind regards, Wim.
| |