lkml.org 
[lkml]   [2010]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: struct fanotify_event_metadata
Date
On Thursday 19 August 2010 17:44:29 Tvrtko Ursulin wrote:
> On Saturday 14 Aug 2010 18:44:38 Andreas Schwab wrote:
> > The pid field of struct fanotify_event_metadata has 64 bits which looks
> > excessive. Wouldn't it make sense to make it 32 bits and swap it with
> > the mask field? That would avoid the unaligned mask field, and remove
> > the need for the packed attribute.
>
> No one seems to have picked up on this what I thought was an obvious good
> idea.

Yes, the pid field should be shrunk; it is a 32-bit value in user-space even
on 64-bit platforms. I also don't see that we'll ever need a 64-bit mask
actually.

Andreas


\
 
 \ /
  Last update: 2010-08-19 18:15    [W:0.103 / U:0.500 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site