Messages in this thread | | | Subject | Re: [RFC][PATCH] introduce ptr_diff() | From | Bernd Petrovitsch <> | Date | Thu, 19 Aug 2010 15:05:13 +0200 |
| |
On Don, 2010-08-19 at 14:59 +0200, Andi Kleen wrote: > > If so, the warning seems valid as sizeof(struct page) is probably not > > (always) a power of 2. On a native build on x86_64 it is 56 bytes > > hereover. > > Hmm .... > > gcc just generats a mull with inverted value. mull is cheap on any > reasonable CPU. Please fix sparse.
Not that I really know the code of sparse but what would be an acceptable condition (except plain simply disabling/removing the warning as such)? No warning if it's a constant value (read: explicit or sizeof())?
Bernd -- Bernd Petrovitsch Email : bernd@petrovitsch.priv.at LUGA : http://www.luga.at
| |