lkml.org 
[lkml]   [2010]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -v3] perf, x86: try to handle unknown nmis with running perfctrs
On 19.08.10 06:45:53, Peter Zijlstra wrote:
> I queued it with that part changed to:
>
> + this_nmi = percpu_read(irq_stat.__nmi_count);
> + if ((handled > 1) ||
> + /* the next nmi could be a back-to-back nmi */
> + ((__get_cpu_var(nmi).marked == this_nmi) &&
> + (__get_cpu_var(nmi).handled > 1))) {
> + /*
> + * We could have two subsequent back-to-back nmis: The
> + * first handles more than one counter, the 2nd
> + * handles only one counter and the 3rd handles no
> + * counter.
> + *
> + * This is the 2nd nmi because the previous was
> + * handling more than one counter. We will mark the
> + * next (3rd) and then drop it if unhandled.
> + */
> + __get_cpu_var(nmi).marked = this_nmi + 1;
> + __get_cpu_var(nmi).handled = handled;
> + }
>
> return NOTIFY_STOP;
> }

I am fine with this. Thanks Peter.

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center



\
 
 \ /
  Last update: 2010-08-19 14:41    [W:0.167 / U:4.528 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site