lkml.org 
[lkml]   [2010]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC][PATCH] introduce ptr_diff()
    Date
    Namhyung Kim <namhyung@gmail.com> writes:

    > When I compiled allyesconfig'ed kernel with C=1, I got 1519 lines of
    > following message:
    >
    > include/linux/mm.h:599:16: warning: potentially expensive pointer subtraction
    >
    > which is around 10% of total warnings. this was caused by page_to_pfn() macro
    > so I think it's worth to remove it by calculating pointer subtraction
    > manually.

    IMHO it would be better to simply disable the warning in sparse instead
    of uglying the code just to work around sparse bogosity. It doesnt' seem
    to make much sense. A subtraction followed by a shift is not expensive.

    -Andi

    --
    ak@linux.intel.com -- Speaking for myself only.


    \
     
     \ /
      Last update: 2010-08-19 14:25    [W:0.019 / U:211.772 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site