lkml.org 
[lkml]   [2010]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] ARM: uaccess: Implement strict user copy checks
Date
On Wednesday 18 August 2010, Stephen Boyd wrote:
> So the only sticking point now is that x86, parisc, and arm use warnings
> and errors but s390 only uses warnings. I guess I'll reword it to be:
>
> Enabling this option turns a certain set of sanity checks for
> user copy operations into compile time warnings/errors.
>
> The copy_from_user() etc checks are there to help test if there
> are sufficient security checks on the length argument of the
> copy operation, by having gcc prove that the argument is
> within bounds.
>
> If unsure, or if you run an older (pre 4.4) gcc where this
> option is a no-op, say N.
>
> or I'll add a patch to make s390 trigger an error when this is enabled?

(Taking Martin and Heiko on Cc for s390)

I'd strongly suggest making the behavior the same for everyone. It should
be fairly easy to make sure none of these warnings ever triggers
on s390, because most of the Linux device driver code does not get build
there anyway.

I'd also drop the part about old compilers and just say
"If unsure, say N".

Arnd


\
 
 \ /
  Last update: 2010-08-19 13:11    [W:0.355 / U:0.348 seconds]
©2003-2014 Jasper Spaans. Advertise on this site