Messages in this thread | | | Date | Tue, 17 Aug 2010 22:14:38 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] Input: fix faulty XXinput_* calls |
| |
On Tue, Aug 17, 2010 at 09:26:25AM -0700, Dmitry Torokhov wrote: > On Tue, Aug 17, 2010 at 04:38:51PM +0200, Daniel Mack wrote: > > On Sat, Aug 14, 2010 at 11:52:13PM +0200, Geert Uytterhoeven wrote: > > > On Thu, Aug 12, 2010 at 18:22, Dmitry Torokhov > > > <dmitry.torokhov@gmail.com> wrote: > > > > From: Daniel Mack <daniel@caiaq.de> > > > > > > > > They've been introduced by 987a6c02 ("Input: switch to input_abs_*() > > > > access functions") and they appear to be some kind of debug left-over. > > > > > > > > [Dmitry Torokhov: these are my fault - I added XX prefixes in places where > > > > I wanted to do additional review of the code but failed to actually do > > > > that in these particular instances.] > > > > > > > > Signed-off-by: Daniel Mack <daniel@caiaq.de> > > > > Signed-off-by: Dmitry Torokhov <dtor@mail.ru> > > > > --- > > > > > > > > drivers/input/joystick/amijoy.c | 2 +- > > > > > > Thanks, amijoy.c compiles now. > > > > > > But hil_kbd.c still doesn't compile: > > > > > > > diff --git a/drivers/input/keyboard/hil_kbd.c b/drivers/input/keyboard/hil_kbd.c > > > > index ddd5afd..dcc86b9 100644 > > > > --- a/drivers/input/keyboard/hil_kbd.c > > > > +++ b/drivers/input/keyboard/hil_kbd.c > > > > @@ -235,7 +235,7 @@ static void hil_dev_handle_ptr_events(struct hil_dev *ptr) > > > > if (val < input_abs_min(dev, ABS_X + i)) > > > > input_abs_set_min(dev, ABS_X + i, val); > > > > if (val > input_abs_max(dev, ABS_X + i)) > > > > > > error: implicit declaration of function ‘input_abs_max’. > > > > > > And indeed, input_abs_max() does not exist, while hil_kbd.c has 4 callers. > > > > Sorry about that. hil_kbd wasn't built on my system with an > > allmodconfig, as I just got to know. Below is a fix for this unfortunate > > trouble. > > > > I think there still a couple of spots need to be adjusted. How about > this one? (Sorry for the silence, I'm in the middle of a vacation).
And still there were more issues (missing semicolons, I think they were there for a long time as TABLET_AUTOADJUST is not normally defined). I have a fix that makes hil_kbd.c compile in my tree and I will post a pull request in a day or so.
Thanks.
-- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |