lkml.org 
[lkml]   [2010]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateWed, 18 Aug 2010 12:10:02 +0100
FromAndy Whitcroft <>
SubjectRe: [PATCH] checkpatch: check for incorrect permissions
On Fri, Aug 13, 2010 at 10:25:29AM +0530, Rabin VINCENT wrote:
> On Thu, Aug 12, 2010 at 23:02:22 +0200, Andrew Morton wrote:
> > On Thu, 12 Aug 2010 10:45:45 +0530
> > Rabin Vincent <rabin.vincent@stericsson.com> wrote:
> > > # extract the filename as it passes
> > > - if ($line=~/^\+\+\+\s+(\S+)/) {
> > > + if ($line=~/^\+\+\+\s+(\S+)/ || $line=~/^diff\s.*?(\S+)$/) {
> >
> > Breakage. This causes the false warning:
> >
> > WARNING: patch prefix 'drivers' exists, appears to be a -p0 patch
>
> I've fixed this by matching for the filename in the diff line only when
> it's "diff --git". Also prevented a double-print of the "do not modify
> file in include/asm" error.
>
> From b854ea24f1bd5391a63d8d4e2aa63e1c10870816 Mon Sep 17 00:00:00 2001
> From: Rabin Vincent <rabin.vincent@stericsson.com>
> Date: Wed, 11 Aug 2010 14:45:45 +0530
> Subject: [PATCHv2] checkpatch: check for incorrect permissions

That one looks better. I've pull this updated one (slightly modified)
into my tree.

Andrew, will send you this shortly.

-apw


\
 
 \ /
  Last update: 2010-08-18 13:13    [from the cache]
©2003-2010