Messages in this thread | | | Date | Wed, 18 Aug 2010 00:30:28 +0200 | From | Frederic Weisbecker <> | Subject | Re: [BUG][reiserfs] page fault during kernel boot |
| |
On Tue, Aug 17, 2010 at 11:25:25AM +0300, Marin Mitov wrote: > Hi all, > > The function: reiserfs_evict_inode() ends with: > > <snip> > out: > end_writeback(inode); /* note this must go after the journal_end to prevent deadlock */ > dquot_drop(inode); > inode->i_blocks = 0; > reiserfs_write_unlock_once(inode->i_sb, depth); > > no_delete: > end_writeback(inode); > dquot_drop(inode); > } > <snip> > > When goto out path is taken, > > end_writeback(inode); > dquot_drop(inode); > > are executed twice, leading to page fault (in my case) during the kernel boot. > > Add return; before no_delete label (but I am not quite sure that this is correct :-). > > Signed-off-by: Marin Mitov <mitov@issp.bas.bg>
In fact the sam patch has been submitted and applied to the vfs tree already:
http://lkml.org/lkml/2010/8/11/98
The patch will probably reach mainline soon.
Thanks.
| |