lkml.org 
[lkml]   [2010]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 10/16] drivers/net/wireless/wl12xx: Use available error codes
    From
    Date
    On Mon, 2010-08-16 at 18:27 +0200, ext Julia Lawall wrote:
    > From: Julia Lawall <julia@diku.dk>
    >
    > Error codes are stored in ret, but the return value is always 0. Return
    > ret instead.
    >
    > The semantic match that finds this problem is as follows:
    > (http://coccinelle.lip6.fr/)
    >
    > // <smpl>
    > @r@
    > local idexpression x;
    > constant C;
    > @@
    >
    > if (...) { ...
    > x = -C
    > ... when != x
    > (
    > return <+...x...+>;
    > |
    > return NULL;
    > |
    > return;
    > |
    > * return ...;
    > )
    > }
    > // </smpl>
    >
    > Signed-off-by: Julia Lawall <julia@diku.dk>
    >
    > ---


    This was indeed a bug. Thanks!

    Acked-by: Luciano Coelho <luciano.coelho@nokia.com>

    --
    Cheers,
    Luca.



    \
     
     \ /
      Last update: 2010-08-17 07:53    [W:0.031 / U:120.188 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site