Messages in this thread | | | Date | Tue, 17 Aug 2010 19:58:51 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH] fs.h: introduce functions to get/set file->private_data |
| |
On Tue, Aug 17, 2010 at 10:26:13AM -0700, Joe Perches wrote: > On Tue, 2010-08-17 at 04:54 -0400, Christoph Hellwig wrote: > > On Mon, Aug 16, 2010 at 09:03:55PM -0400, Ted Ts'o wrote: > > > And spatch could also be used to rename private_data to f_private_data > > > if people really cared.... > > Agreed, that's much better than adding useless accessors. > > Against Linus' current, it's ~850KB. > Anyone really want it?
This clearly shows how big the effort would be to introduce access functions. And if the only gain is grepability then such a cleanup patch is far more convinient.
It takes minimum effort to create and test, and if you can get ack from Ted and/or Christoph there is a good chance Linus would take it right before/after -rc1.
You obviously need to convince him that the patch has seen decent build testing.
Sam
| |