Messages in this thread | | | Date | Tue, 17 Aug 2010 17:39:15 +0100 | From | Andy Whitcroft <> | Subject | Re: [PATCH] scripts: checkpatch.pl |
| |
On Thu, Jun 24, 2010 at 08:27:30AM +0200, Raffaele Recalcati wrote: > 2010/6/23 Andrew Morton <akpm@linux-foundation.org> > > > On Wed, 23 Jun 2010 11:49:21 +0200 > > Raffaele Recalcati <lamiaposta71@gmail.com> wrote: > > > > > From: Raffaele Recalcati <raffaele.recalcati@bticino.it> > > > > > > I've got a false positive when spaces are present > > > at the beginning of a line. > > > So I add this check, obviously outside comments. > > > This patch is compatible with the actual mainline, > > > I mean 7e27d6e778cd87b6f2415515d7127eba53fe5d02 commit. > > > > I don't really understand that. It would help if the changelog > > were to include a copy of the code which triggers this "false > > positive", and a copy of the incorrect checkpatch.pl output. > > > > Thanks. > > > > > Would be nice a changelog like this? > > ----start changelog----------- > I've got a false positive when spaces are present at the beginning of a > line. > So I add this check, obviously excluding to check the lines in the middle of > comments.
This check seems to be causing regressions for valid combinations. I have a patch to this patch which seems to fix it, I am currently fixing the test suite and test it generally.
Andrew, will get the delta up to you shortly.
-apw
| |