Messages in this thread | | | Date | Tue, 17 Aug 2010 11:14:32 -0400 | Subject | Re: [uClinux-dev] [PATCH] m68knommu : Fix strace support for 68328/68360 | From | Mike Frysinger <> |
| |
On Tue, Aug 17, 2010 at 11:11 AM, Philippe De Muyter wrote: > do_trace: > - movel #-ENOSYS,%sp@(PT_OFF_D0) /* needed for strace*/ > + movel #-ENOSYS,%sp@(PT_OFF_D0) /* needed for strace*/ > subql #4,%sp > > -1: movel %d0,%sp@(PT_OFF_D0) /* save the return value */ > +1: movel %d0,%sp@(PT_OFF_D0) /* save the return value */ > subql #4,%sp /* dummy return address */ > /* save top of frame*/ > - pea %sp@ > - jbsr set_esp0 > - addql #4,%sp > + pea %sp@ > + jbsr set_esp0 > + addql #4,%sp > jbsr %a0@ > - movel %d0,%sp@(PT_OFF_D0) /* save the return value*/ > + movel %d0,%sp@(PT_OFF_D0) /* save the return value*/ > > ret_from_exception: > - btst #5,%sp@(PT_OFF_SR) /* check if returning to kernel*/ > + btst #5,%sp@(PT_OFF_SR) /* check if returning to kernel*/ > jeq Luser_return /* if so, skip resched, signals*/
unless i'm missing something, you're only changing whitespace here. and these account for more than half the patch. please keep whitespace changes separate from real changes. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |