Messages in this thread | | | Date | Tue, 17 Aug 2010 15:56:37 +0200 | From | Tejun Heo <> | Subject | Re: [PATCH block#for-2.6.36-post] block: fix incorrect bio/request flag conversion in md |
| |
Hello,
On 08/17/2010 03:56 PM, Christoph Hellwig wrote: > On Mon, Aug 16, 2010 at 04:21:25PM +0200, Tejun Heo wrote: >> Commit 74450be1 (block: unify flags for struct bio and struct request) >> incorrectly converted @do_sync in md raid1 and raid10 make_requst() >> functions. >> >> @do_sync is now supposed to carry the actual flag bit and directly >> OR'd into bio->bi_rw but is still a bool and thus carries either 0 or >> 1 instead of the actual flag bit. This makes REQ_SYNC ignored on >> writes and flips the direction of READ_SYNCs to WRITEs. >> >> Fix it by making @do_sync unsigned integers. > > Yeah, you're the fourth person coming up with this independently. Now > all we need is to get one of the patches actually into Linus tree.
Ah, that's good to know. It's not in mainline yet, so I guess we should just wait for Jens to come back.
Thanks.
-- tejun
| |