lkml.org 
[lkml]   [2010]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: ioctl definition - has it changed recently?
On 17.08.2010 15:51, Piotr Hosowicz wrote:
> On 17.08.2010 15:18, Arnd Bergmann wrote:
>> On Tuesday 17 August 2010, Piotr Hosowicz wrote:
>>>>> Just take a look at all the other patches that went into the
>>>>> kernel to do this for other drivers.
>>>
>>> I do not know how to find them. :-(
>>
>> git log -p -S"unlocked_ioctl"
>
> Thanks a lot.
>
>>>> It seems different. How to change it? Now it works, I built it without
>>>> your remarks, exactly how I described on my blog:
>>>>
>>>> http://phosowicz.jogger.pl/2010/08/15/nvidia-graphics-in-fresh-kernels/
>>>
>>> Ok, as I wrote the prototypes differ. What should I do with the inode
>>> parameter?
>>
>> It's normally not needed.
>
> It seems so because the implementation nowwhere refers to the inode
> parameter. But I guess it won't be OK to just remove this parameter from
> the declaraion and the implemetation because some other NVidia code may
> refer to this parameter, pass it and so on. Potentially scrambling
> (spoiling) the parameter stack.

This is as I said, I just commented inode parameter and it wont build:

/root/nvidia/NVIDIA-Linux-x86_64-256.44/kernel/nv.c: At top level:



/root/nvidia/NVIDIA-Linux-x86_64-256.44/kernel/nv.c:426: warning:
initialization from incompatible pointer type


/root/nvidia/NVIDIA-Linux-x86_64-256.44/kernel/nv.c: In function
‘nv_kern_unlocked_ioctl’:


/root/nvidia/NVIDIA-Linux-x86_64-256.44/kernel/nv.c:3062: warning:
passing argument 1 of ‘nv_kern_ioctl’ from incompatible pointer type


/root/nvidia/NVIDIA-Linux-x86_64-256.44/kernel/nv.c:2876: note: expected
‘struct file *’ but argument is of type ‘struct inode *’


/root/nvidia/NVIDIA-Linux-x86_64-256.44/kernel/nv.c:3062: warning:
passing argument 2 of ‘nv_kern_ioctl’ makes integer from pointer without
a cast

/root/nvidia/NVIDIA-Linux-x86_64-256.44/kernel/nv.c:2876: note: expected
‘unsigned int’ but argument is of type ‘struct file *’


/root/nvidia/NVIDIA-Linux-x86_64-256.44/kernel/nv.c:3062: error: too
many arguments to function ‘nv_kern_ioctl’


/root/nvidia/NVIDIA-Linux-x86_64-256.44/kernel/nv.c: In function
‘nv_kern_compat_ioctl’:


/root/nvidia/NVIDIA-Linux-x86_64-256.44/kernel/nv.c:3071: warning:
passing argument 1 of ‘nv_kern_ioctl’ from incompatible pointer type


/root/nvidia/NVIDIA-Linux-x86_64-256.44/kernel/nv.c:2876: note: expected
‘struct file *’ but argument is of type ‘struct inode *’


/root/nvidia/NVIDIA-Linux-x86_64-256.44/kernel/nv.c:3071: warning:
passing argument 2 of ‘nv_kern_ioctl’ makes integer from pointer without
a cast

/root/nvidia/NVIDIA-Linux-x86_64-256.44/kernel/nv.c:2876: note: expected
‘unsigned int’ but argument is of type ‘struct file *’


/root/nvidia/NVIDIA-Linux-x86_64-256.44/kernel/nv.c:3071: error: too
many arguments to function ‘nv_kern_ioctl’

Regards,

Piotr Hosowicz

--
Zatrzymuje się samochód na sejmowym parkingu. Podchodzi do niego
ochroniarz i mówi:
- Pan tu parkuje?! Tu Sejm ... Ministrowie, politycy, posłowiei ...
- Dzięki, włączę alarm.
NP: -
NB: 2.6.36-rc1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-08-17 16:01    [from the cache]
©2003-2011 Jasper Spaans