Messages in this thread | | | Date | Mon, 16 Aug 2010 20:33:17 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 2/5] virtio_blk: implement REQ_FLUSH/FUA support |
| |
On Mon, Aug 16, 2010 at 06:52:00PM +0200, Tejun Heo wrote: > From: Tejun Heo <tj@kernle.org> > > Remove now unused REQ_HARDBARRIER support and implement REQ_FLUSH/FUA > support instead. A new feature flag VIRTIO_BLK_F_FUA is added to > indicate the support for FUA.
I'm not sure it's worth it. The pure REQ_FLUSH path works not and is well tested with kvm/qemu. We can still easily add a FUA bit, and even a pre-flush bit if the protocol roundtrips matter in real life benchmarking.
| |