lkml.org 
[lkml]   [2010]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH 2/9] RapidIO, powerpc/85xx: modify RIO port-write interrupt handler
Date
From
Micha Nelissen wrote:
>
> Alexandre Bounine wrote:
> > - Rearranged RIO port-write interrupt handling to perform message
buffering
> > as soon as possible.
>
> I don't understand this comment: you still schedule work to read the
> port-write queue; so how is this message buffering performed as soon
as
> possible?


Compared to the original code, I rearranged order of checking interrupt
status bits to check the queue status first. The 85xx PW controller is
capable to receive and keep only one PW message. Therefore, I copy it
into the driver's FIFO and re-enable HW Rx queue (it is called queue but
can accept only one entry) ASAP. I have a test setup that is capable
generate multiple PW messages and see many messages discarded by PW
controller
because of this single-entry HW queue.

>
> > - Modified to disable port-write controller when clearing
Transaction Error (TE)
> > bit.
> > /* Schedule deferred processing if PW was received */
> > - if (ipwsr & RIO_IPWSR_QFI) {
> > + if ((ipwmr & RIO_IPWMR_QFIE) && (ipwsr & RIO_IPWSR_QFI)) {
>
> Why check the QFIE bit also?

Oops! Leftover from some testing. Will clean it up.

>
> > +pw_done:
> > + if (epwisr & 0x80000000) {
>
> Magic value.


Agree. Will correct.




\
 
 \ /
  Last update: 2010-08-16 17:31    [W:0.083 / U:7.320 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site