Messages in this thread | | | Subject | Re: [PATCH] perf tools: Don't use brace expansion. | From | Peter Zijlstra <> | Date | Mon, 16 Aug 2010 16:30:43 +0200 |
| |
On Mon, 2010-08-16 at 16:09 +0200, Bernd Petrovitsch wrote:
> > -$(shell sh -c 'mkdir -p $(OUTPUT)scripts/{perl,python}/Perf-Trace-Util/' 2> /dev/null) > > -$(shell sh -c 'mkdir -p $(OUTPUT)util/{ui/browsers,scripting-engines}/' 2> /dev/null)
> The other solution is to use standard-make features like in > mkdir -p $(foreach d,ui/browsers scripting-engines,$(OUTPUT)util/$(d)/) 2> /dev/null > > Is there actually a specific reason for the > $(shell sh -c '...') > around? > It looks superflous.
I think the reason is is that nobody who touched that file really knew make all that well. Your version looks fine to me.
| |