Messages in this thread | | | Subject | Re: [PATCH] perf tools: Don't use brace expansion. | From | Bernd Petrovitsch <> | Date | Mon, 16 Aug 2010 16:09:21 +0200 |
| |
On Mon, 2010-08-16 at 21:41 +0900, Kusanagi Kouichi wrote: > DASH doesn't support brace expansion. > > Signed-off-by: Kusanagi Kouichi <slash@ac.auone-net.jp> > --- > tools/perf/Makefile | 6 ++++-- > 1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/Makefile b/tools/perf/Makefile > index 41abb90..8fa851b 100644 > --- a/tools/perf/Makefile > +++ b/tools/perf/Makefile > @@ -157,8 +157,10 @@ all:: > # > # Define NO_DWARF if you do not want debug-info analysis feature at all. > > -$(shell sh -c 'mkdir -p $(OUTPUT)scripts/{perl,python}/Perf-Trace-Util/' 2> /dev/null) > -$(shell sh -c 'mkdir -p $(OUTPUT)util/{ui/browsers,scripting-engines}/' 2> /dev/null) > +$(shell sh -c 'mkdir -p $(OUTPUT)scripts/perl/Perf-Trace-Util/' 2> /dev/null) > +$(shell sh -c 'mkdir -p $(OUTPUT)scripts/python/Perf-Trace-Util/' 2> /dev/null) > +$(shell sh -c 'mkdir -p $(OUTPUT)util/ui/browsers/' 2> /dev/null) > +$(shell sh -c 'mkdir -p $(OUTPUT)util/scripting-engines/' 2> /dev/null) > $(shell sh -c 'mkdir $(OUTPUT)bench' 2> /dev/null) > > $(OUTPUT)PERF-VERSION-FILE: .FORCE-PERF-VERSION-FILE
The other solution is to use standard-make features like in mkdir -p $(foreach d,ui/browsers scripting-engines,$(OUTPUT)util/$(d)/) 2> /dev/null
Is there actually a specific reason for the $(shell sh -c '...') around? It looks superflous.
Bernd -- Bernd Petrovitsch Email : bernd@petrovitsch.priv.at LUGA : http://www.luga.at
| |