lkml.org 
[lkml]   [2010]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset for samsung2GbX8
On Mon, Aug 16, 2010 at 9:05 PM, David Woodhouse <dwmw2@infradead.org> wrote:
> On Mon, 2010-08-16 at 20:55 +0800, Eric Miao wrote:
>> On Mon, Aug 16, 2010 at 8:49 PM, Haojian Zhuang <hzhuang1@marvell.com> wrote:
>> > http://lists.infradead.org/pipermail/linux-mtd/2010-July/subject.html
>> >
>> > They're re-posted in July. Please search the subjects in that page. They're totally 29 patches.
>> >
>> > By the way, David, what's the result of review on these patches? We already posted for several times.
>> >
>>
>> I've actually reviewed some of the patches and gave my Ack. For those
>> patches, I think they can be merged early.
>>
>> And overall, they look good. Yet 29 patch in a whole is still a bit too
>> much, would be good to see them logically be separated into several
>> patch series.
>
> You had some criticism of patch #1 in the sequence, and some questions.
>

So they need to be addressed. Lei, could you please come up with
an updated patch?

> I didn't look much harder than that, iirc... although looking back now
> it seems that the rest of your responses to the sequence were largely
> positive.
>
> Are you happy with the first patch, and if so shall I go ahead and
> import the whole sequence with your Acked-By:?
>

I'm generally OK, but still think it would be good to have another around
of review before they can be merged.


\
 
 \ /
  Last update: 2010-08-16 15:57    [W:0.257 / U:0.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site