Messages in this thread Patch in this message | | | From | Lei Wen <> | Date | Mon, 16 Aug 2010 05:34:38 -0700 | Subject | RE: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset for samsung2GbX8 |
| |
Hi Axel,
I suggest not merge your patch into mainline code. Since I have a large series of patch which reconstruct the nand flash definition, this fix would no longer be needed.
Thanks, Lei
-----Original Message----- From: Eric Miao [mailto:eric.y.miao@gmail.com] Sent: 2010年8月16日 20:22 To: Axel Lin Cc: linux-kernel; David Woodhouse; linux-mtd@lists.infradead.org; Lei Wen; Haojian Zhuang Subject: Re: [PATCH] [MTD] [NAND] pxa3xx: fix timing and cmdset for samsung2GbX8
Cc'ed Lei and Haojian.
On Mon, Aug 16, 2010 at 4:50 PM, Axel Lin <axel.lin@gmail.com> wrote: > This patch adds timing settings for samsung2GbX8 and > fixes the cmdset settings. samsung2GbX8 is large page. > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > --- > drivers/mtd/nand/pxa3xx_nand.c | 16 ++++++++++++++-- > 1 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c > index 4d89f37..47c0442 100644 > --- a/drivers/mtd/nand/pxa3xx_nand.c > +++ b/drivers/mtd/nand/pxa3xx_nand.c > @@ -227,9 +227,21 @@ static struct pxa3xx_nand_flash samsung512MbX16 = { > .chip_id = 0x46ec, > }; > > +static struct pxa3xx_nand_timing samsung2GbX8_timing = { > + .tCH = 5, > + .tCS = 20, > + .tWH = 10, > + .tWP = 12, > + .tRH = 10, > + .tRP = 12, > + .tR = 25000, > + .tWHR = 60, > + .tAR = 10, > +}; > + > static struct pxa3xx_nand_flash samsung2GbX8 = { > - .timing = &samsung512MbX16_timing, > - .cmdset = &smallpage_cmdset, > + .timing = &samsung2GbX8_timing, > + .cmdset = &largepage_cmdset, > .page_per_block = 64, > .page_size = 2048, > .flash_width = 8, > -- > 1.7.2 > > > >
| |