lkml.org 
[lkml]   [2010]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] mm: code improvement of check_stack_guard_page
    On Sat, Aug 14, 2010 at 10:15 PM, jovi zhang <bookjovi@gmail.com> wrote:
    >
    > little code improvement of check_stack_guard_page function.
    > this commit is on top of commit "mm: keep a guard page below a
    > grow-down stack segment" of linus.

    I don't think your patch is in any way wrong, but I just checked, and
    it makes absolutely zero difference to the code generation at least
    for my version of gcc. The resulting assembly is identical except for
    the line numbers that changed (BUG_ON() line/file information and
    debug information).

    So I think I prefer the shallower indentation.

    Linus


    \
     
     \ /
      Last update: 2010-08-15 20:01    [W:0.038 / U:0.072 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site